Benjamin Lee 8bffcfe82b remove sync response cache ... This cache can serve invalid responses, and has an extremely low hit rate. It serves invalid responses because because it's only keyed off the `since` parameter, but many of the other request parameters also affect the response or it's side effects. This will become worse once we implement filtering, because there will be a wider space of parameters with different responses. This problem is fixable, but not worth it because of the low hit rate. The low hit rate is because normal clients will always issue the next sync request with `since` set to the `prev_batch` value of the previous response. The only time we expect to see multiple requests with the same `since` is when the response is empty, but we don't cache empty responses. This was confirmed experimentally by logging cache hits and misses over 15 minutes with a wide variety of clients. This test was run on matrix.computer.surgery, which has only a few active users, but a large volume of sync traffic from many rooms. Over the test period, we had 3 hits and 5309 misses. All hits occurred in the first minute, so I suspect that they had something to do with client recovery from an offline state. The clients that were connected during the test are: - element web - schildichat web - iamb - gomuks - nheko - fractal - fluffychat web - fluffychat android - cinny web - element android - element X android Fixes: #336		2024-05-17 18:13:11 -04:00
..
client_server	remove sync response cache	2024-05-17 18:13:11 -04:00
ruma_wrapper	remove this unnecessary log, use debug_warn	2024-05-03 01:52:29 -04:00
mod.rs	make everything pub(crate) instead of pub	2024-04-26 02:03:40 -04:00
server_server.rs	resolve half of the integer_arithmetic lints, couple misc changes	2024-05-06 03:45:10 -04:00