feat: appeased the clippy gods

src/database/key_value/acl.rs

@@ -67,7 +67,7 @@ impl Data for KeyValueDatabase {
                 None => return,
             };
             set.insert(AclDatabaseEntry {
-                mode: mode,
+                mode,
                 hostname: parsed_host,
             });
         });

src/service/acl/data.rs

@@ -24,7 +24,7 @@ pub enum AclMode {
 }
 
 impl AclMode {
-    pub fn to_emoji(&self) -> char {
+    pub fn to_emoji(self) -> char {
         match self {
             AclMode::Block => '❎',
             AclMode::Allow => '✅',

src/service/acl/mod.rs

@@ -44,7 +44,7 @@ impl Service {
 
     pub fn add_acl(&self, host: Host, mode: AclMode) -> crate::Result<()> {
         self.db.add_acl(AclDatabaseEntry {
-            mode: mode,
+            mode,
             hostname: host,
         })
     }
@@ -59,7 +59,7 @@ impl Service {
             );
             return false;
         };
-        return self.is_federation_with_allowed(hostname);
+        self.is_federation_with_allowed(hostname)
     }
 
     /// same as federation_with_allowed however it can work with the fedi_dest type
@@ -70,7 +70,7 @@ impl Service {
             warn!("cannot deserialise hostname for server with name {:?}", srv);
             return false;
         };
-        return self.is_federation_with_allowed(hostname);
+        self.is_federation_with_allowed(hostname)
     }
     /// is federation allowed with this particular server?
     pub fn is_federation_with_allowed(&self, server_host_name: Host<String>) -> bool {

src/service/mod.rs

@@ -122,7 +122,7 @@ impl Services {
 
             globals: globals::Service::load(db, config)?,
             acl: acl::Service {
-                db: db,
+                db,
                 acl_config: acl_conf,
             },
         })